Skip to content

Conversation

@nurdism
Copy link

@nurdism nurdism commented Aug 7, 2025

  • Version of modified component bumped
  • CI passing (not sure how to run this)

This adds a config option to include a rounder cb for LVGL9, addresses #616


Note

Adds rounder_cb to display config and calls it on LVGL9 invalidate/refr events; updates README and changelog.

  • API (LVGL Port Display)
    • Add lvgl_port_rounder_cb_t and rounder_cb field to lvgl_port_display_cfg_t in include/esp_lvgl_port_disp.h.
  • Runtime (LVGL9)
    • Invoke rounder_cb during LV_EVENT_INVALIDATE_AREA/LV_EVENT_REFR_REQUEST in src/lvgl9/esp_lvgl_port_disp.c to adjust the invalidated lv_area_t.
  • Docs
    • Update README.md example to show .rounder_cb = my_rounder_cb in lvgl_port_display_cfg_t.
  • Changelog
    • Note new feature: option to include a rounder callback.

Written by Cursor Bugbot for commit 6b8ad7d. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings August 7, 2025 04:06
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a rounder callback configuration option for LVGL9 displays in the ESP LVGL port component. The rounder callback allows customization of display area boundaries before invalidation events.

  • Added lvgl_port_rounder_cb_t typedef and rounder_cb field to display configuration
  • Implemented callback invocation in the display invalidate event handler
  • Updated component version from 2.6.0 to 2.7.0

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
esp_lvgl_port_disp.h Adds rounder callback typedef and configuration field for LVGL9
esp_lvgl_port_disp.c Implements rounder callback invocation in invalidate event handler
idf_component.yml Bumps component version to 2.7.0
README.md Adds example usage of rounder_cb in display configuration
CHANGELOG.md Documents the new rounder callback feature

@github-actions github-actions bot changed the title feat(esp_lvgl_port): Add rounder_cb option for displays feat(esp_lvgl_port): Add rounder_cb option for displays (BSP-705) Aug 7, 2025
@espzav espzav added this to the esp_lvgl_port 2.8.0 milestone Dec 2, 2025
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nurdism Thank you for this feature! I am sorry for late review. LGTM

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.


### Features
- Added option to include a rounder callback for LVGL 9
-
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Empty bullet point in changelog

Line 7 contains an empty bullet point (- followed by nothing) in the changelog's Features section. This appears to be incomplete or accidentally committed text that was left behind during editing.

Fix in Cursor Fix in Web

Added option to include a rounder callback for LVGL 9.
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nurdism Sorry for waiting and "bad approve". I decided to add this feature for LVGL8 too and I found some more issues. I created new PR for it: #689
Please, could you look at it and try it with your code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants