-
Notifications
You must be signed in to change notification settings - Fork 177
feat(esp_lvgl_port): Add rounder_cb option for displays (BSP-705) #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a rounder callback configuration option for LVGL9 displays in the ESP LVGL port component. The rounder callback allows customization of display area boundaries before invalidation events.
- Added
lvgl_port_rounder_cb_ttypedef androunder_cbfield to display configuration - Implemented callback invocation in the display invalidate event handler
- Updated component version from 2.6.0 to 2.7.0
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| esp_lvgl_port_disp.h | Adds rounder callback typedef and configuration field for LVGL9 |
| esp_lvgl_port_disp.c | Implements rounder callback invocation in invalidate event handler |
| idf_component.yml | Bumps component version to 2.7.0 |
| README.md | Adds example usage of rounder_cb in display configuration |
| CHANGELOG.md | Documents the new rounder callback feature |
espzav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nurdism Thank you for this feature! I am sorry for late review. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| ### Features | ||
| - Added option to include a rounder callback for LVGL 9 | ||
| - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added option to include a rounder callback for LVGL 9.
espzav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a config option to include a rounder cb for LVGL9, addresses #616
Note
Adds
rounder_cbto display config and calls it on LVGL9 invalidate/refr events; updates README and changelog.lvgl_port_rounder_cb_tandrounder_cbfield tolvgl_port_display_cfg_tininclude/esp_lvgl_port_disp.h.rounder_cbduringLV_EVENT_INVALIDATE_AREA/LV_EVENT_REFR_REQUESTinsrc/lvgl9/esp_lvgl_port_disp.cto adjust the invalidatedlv_area_t.README.mdexample to show.rounder_cb = my_rounder_cbinlvgl_port_display_cfg_t.Written by Cursor Bugbot for commit 6b8ad7d. This will update automatically on new commits. Configure here.